Merged
Conversation
21 tasks
TuThoThai
previously approved these changes
Oct 20, 2025
Contributor
There was a problem hiding this comment.
Review done with @thbar.
Minor comments (mostly for future work):
- in commit Add all missing attributes to the restrictions, the documentation should read "unchanged." instead of "unchanged;". As only a punctuation, it is very minor and would not hinder anything if let unmodified.
- changes made in examples have not been reviewed
- code in Python has not been reviewed
- AI-automated code should be better "flagged" in this repo and massive PR should be divided in smaller pieces, mostly to ease the review for newcomers
The PR is approved considering:
- it reflects the group consensus for v2.0
- breaking existing NeTEx feeds after the merge was a pre-existing agreement for NeTEx v2.0 as these feeds were marked as faulty and the group wanted better automated checks against NeTEx XSD
- it will serve as a good basis for v2.x but mostly v3.0
skinkie
dismissed
TuThoThai’s stale review
The merge-base changed after approval.
TuThoThai
previously approved these changes
Oct 20, 2025
skinkie
dismissed
TuThoThai’s stale review
The merge-base changed after approval.
Contributor
Author
|
@TuThoThai done. |
skinkie
dismissed
TuThoThai’s stale review
The merge-base changed after approval.
TuThoThai
previously approved these changes
Oct 20, 2025
skinkie
dismissed
TuThoThai’s stale review
The merge-base changed after approval.
trurlurl
previously approved these changes
Oct 20, 2025
skinkie
dismissed
trurlurl’s stale review
The merge-base changed after approval.
trurlurl
approved these changes
Oct 20, 2025
TuThoThai
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #970 and partially resolves #973 for References from the attribute level. Importance: this fills the gap of objects that never received attributes, or partial attributes. I'll try to apply defaults, etc. in a next commit, otherwise I'll mark it for review.
Changes: the NameOfClassXXXRefStructure's were renamed to NameOfClassXXXRefStructureType.
All missing attributes were added to XXXRefStructure's.
We would still require software that can assess that a restriction inherited all element, groups, attributes and attributeGroups from its base. My own attempt to compute it took too long.